Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/snowflake): fix regression in approx count distinct #7146

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(ingest/snowflake): fix regression in approx count distinct #7146

merged 1 commit into from
Jan 27, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 26, 2023

Follow up on #7101.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from treff7es January 26, 2023 18:23
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 26, 2023
jjoyce0510
jjoyce0510 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Have we verified against snowflake?

@jjoyce0510 jjoyce0510 merged commit 8c42a1f into datahub-project:master Jan 27, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2
fix(ingest/snowflake): fix regression in approx count distinct (datah…
bb1eb41 
…ub-project#7146)
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2
fix(ingest/snowflake): fix regression in approx count distinct (datah…
4e036f5 
…ub-project#7146)
@hsheth2 hsheth2 deleted the snowflake-profile-fix branch February 14, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @treff7es @jjoyce0510